integration: fix SerialConsistencyTests #186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original cpp-driver allows user to SET the invalid serial consistency. Then, the request is sent with an invalid serial consistency, resulting in a server error. However, rust-driver comes with a type safety in this matter, disallowing the user to set invalid serial consistency, thus we are not able to mimic this behaviour in cpp-rust-driver. We need to adjust the integration test, and assert that setting the invalid serial consistency fails with an error.
We adjusted the test in the previous commit, so now it should be passing during CI.
dkropachev
approved these changes
Oct 9, 2024
Lorak-mmk
approved these changes
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Original cpp-driver allows user to SET the invalid serial consistency.
Then, the request is sent with an invalid serial consistency, resulting in a server error.
However, rust-driver comes with a type safety in this matter, disallowing
the user to set invalid serial consistency, thus we are not able to mimic this behaviour in cpp-rust-driver.
We need to adjust the integration test, and assert that setting the invalid serial consistency fails with an error.
Changes
Adjusted one test in
SerialConsistencyTestssuite, and enabled the test suite in CI.Pre-review checklist
[ ] I have implemented Rust unit tests for the features/changes introduced..github/workflows/build.ymlingtest_filter..github/workflows/cassandra.ymlingtest_filter.